pyo3-build-config: Replace TargetInfo with target_lexicon::Triple
#2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravenexp
force-pushed
the
target-lexicon
branch
3 times, most recently
from
d4b59aa
to
2c4d82d
Compare
messense
approved these changes
Mar 30, 2022
| if !env_vars.any() && is_not_cross_compiling(host, &target_info) { | ||
| return Ok(None); | ||
| } | ||
| // FIXME: This field is currently unused. |
There was a problem hiding this comment.
I guess we don't need to address these FIXMEs right now since we're going to remove cross_compiling in a new minor version.
There was a problem hiding this comment.
Oh, certainly. These FIXMEs will be removed with cross_compiling() in v0.17.
Perhaps I should've used WONTFIX: instead of FIXME: 😁.
Add a new public crate function `cross_compile_from_to()` using `target_lexicon::Triple` arguments instead of plain strings used in `cross_compile()`. Deprecate `pyo3_build_config::cross_compile()` since v0.17. Attempt to extract common code patterns into methods and standalone helper functions. Add docstrings to the new private items. Make some of the new helper functions public within the PyO3 crate and reuse them in the build scripts. Add PYO3_CROSS_PYTHON_VERSION parsing unit test. Add a ChangeLog entry mentioning the new `pyo3-build-config` API.
adamreichold
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new public crate function
cross_compile_from_to()usingtarget_lexicon::Triplearguments instead of plain stringsused in
cross_compile().Attempt to extract common code patterns into methods and standalone
helper functions. Add docstrings to private items.
Make some of the new helper functions public within the PyO3 crate
and reuse them in the build scripts.
No user visible functionality change.