Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather test coverage with stable rust #2286

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Conversation

ricohageman
Copy link
Contributor

This will ensure that the test coverage can be determined using the stable rust release.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

CHANGELOG.md Outdated Show resolved Hide resolved
@davidhewitt
Copy link
Member

Not sure why the coverage jobs are failing... ?

@adamreichold
Copy link
Member

Not sure why the coverage jobs are failing... ?

I think our xtask binary is still forcing a nightly toolchain:

image

let rustc_version =
String::from_utf8(get_output(Command::new("rustc").arg("--version"))?.stdout)
.context("failed to parse rust version as utf8")?;
if !rustc_version.contains("nightly") {
env.insert("RUSTUP_TOOLCHAIN".to_owned(), "nightly".to_owned());
}

@davidhewitt davidhewitt merged commit 1971dd7 into PyO3:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants