Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyo3-build-config: Use "m" ABI tag for libpython 3.7 by default #2288

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

ravenexp
Copy link
Contributor

@ravenexp ravenexp commented Apr 9, 2022

According to https://bugs.python.org/issue36707, this tag is useless
since version 3.4, but also the default until version 3.8.

For example, Debian 10 ships libpython3.7m.so.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep agreed 👍

This probably needs a CHANGELOG entry - something along the lines of "default to m abi tag when choosing libpython link name for Python 3.7 on unix", perhaps?

According to https://bugs.python.org/issue36707, this tag is useless
since version 3.4, but also the default until version 3.8.

For example, Debian 10 ships `libpython3.7m.so`.
@ravenexp ravenexp force-pushed the fix-py37-abi-version branch from cb587a3 to 8f9976a Compare April 9, 2022 10:29
@davidhewitt davidhewitt merged commit 2a54641 into PyO3:main Apr 9, 2022
@ravenexp ravenexp deleted the fix-py37-abi-version branch April 9, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants