ffi: add new 3.11 fields to PyConfig #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field was added in 3.10 but we missed it. This was causing offsets of subsequent fields to be wrong. This could lead to unexpected behavior or even crashes.
These are the new fields in 3.11 so far. 3.11 is supposedly feature frozen, so hopefully we don't need to revisit this struct before 3.11 final.
This was referenced May 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully makes PyConfig compatible with 3.11. I haven't tested this though.
This is based on top of #2370 and should probably be rebased once that PR merges. Only the 2nd commit is unique to this PR. I wish GitHub let you chain stacks of commits together more easily...