Auto generate Windows import libraries when using a pyo3 config file #2372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the build script of
pyo3-ffi
callspyo3-build-config
'sresolve_interpreter_config
functionpyo3/pyo3-ffi/build.rs
Lines 79 to 80 in 87bd10c
when
PYO3_CONFIG_FILE
env var is set, it simply read the file usingInterpreterConfig::from_reader
which missed the "generate import library" setup thus nopython3.dll
/python3y.dll
is generated causing linking errorspyo3/pyo3-build-config/src/lib.rs
Lines 179 to 180 in 87bd10c