Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GILOnceCell::get_or_try_init #2398

Merged
merged 2 commits into from
Dec 26, 2022
Merged

Add GILOnceCell::get_or_try_init #2398

merged 2 commits into from
Dec 26, 2022

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented May 24, 2022

This is similar to OnceCell::get_or_try_init and is very useful for fallible initialization.

mejrs
mejrs requested changes May 28, 2022
View reviewed changes
Copy link
Member

@mejrs mejrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests 😉 Otherwise it looks good to me

src/once_cell.rs Outdated Show resolved Hide resolved
@davidhewitt davidhewitt mentioned this pull request Aug 4, 2022
Merged
3 tasks
@adamreichold adamreichold mentioned this pull request Nov 27, 2022
Closed
7 tasks
@a1phyr a1phyr force-pushed the once_cell_try_init branch from 93ed391 to 79501bc Compare November 29, 2022 13:28
davidhewitt
davidhewitt approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this, and sorry for the slow review. I agree with all comments above; I've just pushed a commit to move the docs around as suggested and will merge this now.

@davidhewitt
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 26, 2022

👎 Rejected by code reviews

@davidhewitt davidhewitt requested a review from mejrs December 26, 2022 20:40
@davidhewitt
Copy link
Member

davidhewitt commented Dec 26, 2022 •
edited
Loading

Hmmm, looks like bors probably wants you to give a green tick please @mejrs 😄

mejrs
mejrs approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@mejrs mejrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mejrs
Copy link
Member

mejrs commented Dec 26, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 26, 2022

Build succeeded:

@bors bors bot merged commit 75ca1b2 into PyO3:main Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold left review comments

@mejrs mejrs mejrs approved these changes

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a1phyr @davidhewitt @mejrs @adamreichold