pymethods: prevent methods sharing the same name #2399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the
#[pymethods]
code generation so that the generated functions have meaningful names and are members of the associated class.In general, the structure of generated code has changed from
to
There are a few nice benefits that this brings:
#[pyo3(name = "foo")]
.replace_self
to removeSelf
from generated code; we don't need this now the generated code is associated with the class.__wrap
(that was actually what motivated me to try this today as I was struggling to debug WIP: new function signature #2302; this idea's been in the back of my mind for a while)