Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow #[classattr] take Python argument #2456

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Allow #[classattr] take Python argument #2456

merged 1 commit into from
Jun 16, 2022

Conversation

ikrivosheev
Copy link
Contributor

Hello! this PR close: #2383

  • an entry in CHANGELOG.md
  • docs to all new functions and / or detail in the guide
  • tests for all new or changed functions

davidhewitt
davidhewitt approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely perfect 💯 ! Thanks very much for this implementation!

@davidhewitt davidhewitt merged commit 1978712 into PyO3:main Jun 16, 2022
@ikrivosheev ikrivosheev deleted the feature/issues-2383_classattribute branch June 16, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[classattr] functions should be able to take Python arguments
2 participants
@ikrivosheev @davidhewitt