-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust 1.62 #2489
Rust 1.62 #2489
Conversation
tests/ui/missing_clone.stderr
Outdated
<&'py LimitOverrunError as pyo3::FromPyObject<'py>> | ||
<&'py PanicException as pyo3::FromPyObject<'py>> | ||
<&'py PyAny as pyo3::FromPyObject<'py>> | ||
and 142 others |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number here seems to fluctuate. Can it be wildcarded out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not aware of a wildcard feature in trybuild.
Wild guess, could it be related to features? Maybe we need to run UI tests only with feature = "full"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no-fail-fast has answered it, looks like different number of Clone
implementations on Windows vs other OS.
I guess it's fine to run this particular UI test just on Linux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no-fail-fast has answered it, looks like different number of
Clone
implementations on Windows vs other OS.
That, and the abi3/full/etc features. I've just made a compile_fail doctest instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I think that's good enough here, thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks again 👍
* Rust 1.62 * Make rust happy * Just use a doctest instead Co-authored-by: mejrs <>
* Rust 1.62 * Make rust happy * Just use a doctest instead Co-authored-by: mejrs <>
* Rust 1.62 * Make rust happy * Just use a doctest instead Co-authored-by: mejrs <>
* Rust 1.62 * Make rust happy * Just use a doctest instead Co-authored-by: mejrs <>
No description provided.