Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safety: abort if dropping panic payloads panic #2544

Merged
merged 1 commit into from
Aug 14, 2022

Conversation

davidhewitt
Copy link
Member

Fixes #2501

src/panic.rs Outdated Show resolved Hide resolved
src/panic.rs Outdated Show resolved Hide resolved
@davidhewitt davidhewitt force-pushed the panic-drop-abort branch 4 times, most recently from bdf076f to e716388 Compare August 14, 2022 07:28
@adamreichold
Copy link
Member

The jobs are queued for an unusual amount of time and I got some API errors while using the UI. Seems like GitHub has a hiccup...

@davidhewitt
Copy link
Member Author

Heh, I'd pushed a broken commit anyway. Hopefully this one passes CI...

@davidhewitt davidhewitt merged commit 8907cab into PyO3:main Aug 14, 2022
@davidhewitt davidhewitt deleted the panic-drop-abort branch August 14, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run_closure and drop_closure unsoundly drop payload on panic
3 participants