Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Fix #2615 by relaxing the type check in extract_sequence. #2620

Closed
wants to merge 3 commits into from
Closed

RFC: Fix #2615 by relaxing the type check in extract_sequence. #2620

wants to merge 3 commits into from

Commits on Sep 19, 2022

  1. Add a Python test exploring from which types a Vec can be extracted.

    @adamreichold
    adamreichold committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    a1b34f0 View commit details
    Browse the repository at this point in the history

  2. Fix #2615 by relaxing the type check in extract_sequence. 

    This allows us to handle types like one-dimensional NumPy arrays which implement
just enough of the sequence protocol to support the extract_sequence function
but are not an instance of the sequence ABC.
    @adamreichold
    adamreichold committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    076efc7 View commit details
    Browse the repository at this point in the history

  3. Further relax extract_sequence as neither PyObject::len nor PyObject:… 

    …:iter actually need the sequence protocol.
    @adamreichold
    adamreichold committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    c2f1810 View commit details
    Browse the repository at this point in the history