Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax extract_sequence to the status quo before 0.17 was released #2631

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Relax extract_sequence to the status quo before 0.17 was released #2631

merged 4 commits into from
Sep 21, 2022

Commits on Sep 21, 2022

  1. Add a Python test exploring from which types a Vec can be extracted.

    @adamreichold
    adamreichold committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    b2da5b2 View commit details
    Browse the repository at this point in the history

  2. Fix #2615 by relaxing the type check in extract_sequence. 

    This allows us to handle types like one-dimensional NumPy arrays which implement
just enough of the sequence protocol to support the extract_sequence function
but are not an instance of the sequence ABC.
    @adamreichold
    adamreichold committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    b6c6f7f View commit details
    Browse the repository at this point in the history

  3. Add changelog entry detailing which behaviour change this does and do… 

    …es not revert.
    @adamreichold
    adamreichold committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    0c30cba View commit details
    Browse the repository at this point in the history

  4. Pin once_cell to fix MSRV build.

    @adamreichold
    adamreichold committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    df933c5 View commit details
    Browse the repository at this point in the history