-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add Python 3.12-dev jobs #2709
Conversation
05fcce7
to
349281d
Compare
Nearly there, however I came across a crash which reported upstream: python/cpython#99708 |
bors r+ |
2709: ci: add Python 3.12-dev jobs r=davidhewitt a=davidhewitt Separately to #2708, time to start testing 3.12 alphas on CI. I imagine this might also take a while for the packages to come available. 2800: allow `**kwargs` to take arguments which conflict with positional-only parameters r=davidhewitt a=davidhewitt Closes #2799 I did a little bit of refactoring at the same time, sorry! The bit which changes behaviour is that in the now-factored-out `handle_kwargs` method, if the keyword argument name is found in the positional-only range then the varkeywords handler is now given a chance to accept it. (Lines 387-390 in new `extract_argument.rs`.) 2811: adjust vectorcall symbols for pypy r=davidhewitt a=davidhewitt Closes #2738 Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
Build failed (retrying...): |
Build failed: |
f0ad820
to
9d50c2b
Compare
bors r+ |
Build failed: |
blocked on #2817 |
The upstream issue seems resolved. Could this just be rebased and retried? |
I think it was fixed for 3.11 but the CPython developers intended to stick with the new changes for 3.12. It might be worth a rebase and rerun although I'm thinking we might want to consider updating to use 3.8's python interpreter initialization APIs and see if that unblocks us. |
I guess this would be something to do post a 0.19 release? Probably together with our MSRV bump when 3.7 reaches EoL and Bookworm hits the shelves. |
bors try |
tryBuild failed: |
bors try |
Looks like our string handling needs further work still, at least the necessary changes to make |
tryBuild failed: |
010f58d
to
35b75db
Compare
@adamreichold I think this branch is now at a state where I'd like to propose we merge it, the falling 3.12 problems shouldn't block us in CI and then we can identify and fix them individually. I think this same setting is what we can also apply for 3.7 so that contributors don't get blocked by the extended support we're trialling. |
Separately to #2708, time to start testing 3.12 alphas on CI. I imagine this might also take a while for the packages to come available.