Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Python 3.12-dev jobs #2709

Merged
merged 2 commits into from
Jun 12, 2023
Merged

ci: add Python 3.12-dev jobs #2709

merged 2 commits into from
Jun 12, 2023

Conversation

davidhewitt
Copy link
Member

Separately to #2708, time to start testing 3.12 alphas on CI. I imagine this might also take a while for the packages to come available.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Oct 25, 2022
@davidhewitt davidhewitt force-pushed the py3.12 branch 3 times, most recently from 05fcce7 to 349281d Compare November 22, 2022 22:19
@davidhewitt
Copy link
Member Author

Nearly there, however I came across a crash which reported upstream: python/cpython#99708

@messense messense added the CI Continuous Integration label Nov 23, 2022
@davidhewitt
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Dec 17, 2022
2709: ci: add Python 3.12-dev jobs r=davidhewitt a=davidhewitt

Separately to #2708, time to start testing 3.12 alphas on CI. I imagine this might also take a while for the packages to come available.

2800: allow `**kwargs` to take arguments which conflict with positional-only parameters r=davidhewitt a=davidhewitt

Closes #2799 

I did a little bit of refactoring at the same time, sorry! The bit which changes behaviour is that in the now-factored-out `handle_kwargs` method, if the keyword argument name is found in the positional-only range then the varkeywords handler is now given a chance to accept it. (Lines 387-390 in new `extract_argument.rs`.)

2811: adjust vectorcall symbols for pypy r=davidhewitt a=davidhewitt

Closes #2738

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 17, 2022

Build failed (retrying...):

bors bot added a commit that referenced this pull request Dec 17, 2022
2709: ci: add Python 3.12-dev jobs r=davidhewitt a=davidhewitt

Separately to #2708, time to start testing 3.12 alphas on CI. I imagine this might also take a while for the packages to come available.

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 17, 2022

Build failed:

@davidhewitt davidhewitt force-pushed the py3.12 branch 2 times, most recently from f0ad820 to 9d50c2b Compare December 17, 2022 12:55
@davidhewitt
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Dec 17, 2022
2709: ci: add Python 3.12-dev jobs r=davidhewitt a=davidhewitt

Separately to #2708, time to start testing 3.12 alphas on CI. I imagine this might also take a while for the packages to come available.

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 17, 2022

Build failed:

@davidhewitt
Copy link
Member Author

blocked on #2817

@adamreichold
Copy link
Member

blocked on #2817

The upstream issue seems resolved. Could this just be rebased and retried?

@davidhewitt
Copy link
Member Author

I think it was fixed for 3.11 but the CPython developers intended to stick with the new changes for 3.12. It might be worth a rebase and rerun although I'm thinking we might want to consider updating to use 3.8's python interpreter initialization APIs and see if that unblocks us.

@adamreichold
Copy link
Member

I'm thinking we might want to consider updating to use 3.8's python interpreter initialization APIs and see if that unblocks us.

I guess this would be something to do post a 0.19 release? Probably together with our MSRV bump when 3.7 reaches EoL and Bookworm hits the shelves.

@adamreichold
Copy link
Member

bors try

bors bot added a commit that referenced this pull request May 10, 2023
@bors
Copy link
Contributor

bors bot commented May 10, 2023

try

Build failed:

@adamreichold
Copy link
Member

bors try

bors bot added a commit that referenced this pull request May 10, 2023
@adamreichold
Copy link
Member

Looks like our string handling needs further work still, at least the necessary changes to make ffi::tests::ascii and ffi::tests::ucs4 are not obvious to me.

@bors
Copy link
Contributor

bors bot commented May 10, 2023

try

Build failed:

@davidhewitt
Copy link
Member Author

@adamreichold I think this branch is now at a state where I'd like to propose we merge it, the falling 3.12 problems shouldn't block us in CI and then we can identify and fix them individually.

I think this same setting is what we can also apply for 3.7 so that contributors don't get blocked by the extended support we're trialling.

@adamreichold adamreichold added this pull request to the merge queue Jun 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 12, 2023
@adamreichold adamreichold added this pull request to the merge queue Jun 12, 2023
Merged via the queue into PyO3:main with commit a053489 Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration CI-build-full CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants