Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for std::num::NonZero integer types #2730

Merged
merged 3 commits into from
Nov 13, 2022
Merged

Add support for std::num::NonZero integer types #2730

merged 3 commits into from
Nov 13, 2022

Conversation

ongchi
Copy link
Contributor

@ongchi ongchi commented Nov 9, 2022

This pull request adds support for various integer types of std::num

Fixes #2650

@adamreichold
Copy link
Member

Please add a news fragment by following the instructions at https://github.com/PyO3/pyo3/blob/main/Contributing.md#documenting-changes Thanks!

src/conversions/std/num.rs Outdated Show resolved Hide resolved
@ongchi ongchi marked this pull request as draft November 10, 2022 15:56
@ongchi ongchi marked this pull request as ready for review November 10, 2022 16:20
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, many thanks for this 👍

@davidhewitt davidhewitt merged commit d060a19 into PyO3:main Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NonZero Int type support
4 participants