-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax indexmap dependency #2849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreichold
reviewed
Jan 1, 2023
gnaaman-dn
force-pushed
the
indexmap-1.9
branch
from
January 1, 2023 18:25
c8befc3
to
843075c
Compare
As the CI indicates, this does indeed need a news fragment describing the change, c.f. https://github.com/PyO3/pyo3/blob/main/Contributing.md#documenting-changes. |
gnaaman-dn
force-pushed
the
indexmap-1.9
branch
from
January 2, 2023 07:28
843075c
to
3e4cf78
Compare
bors r+ |
Build succeeded! And happy new year! 🎉 |
This was referenced Jan 17, 2023
1 task
1 task
This was referenced Mar 12, 2023
This was referenced Mar 26, 2023
1 task
1 task
This was referenced Jun 17, 2023
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Halloo,
Noticed some version resolve errors when trying to use the
indexmap
features.Couldn't find a specific reason for this limitation so I tried upgrading the dependency and running the tests.
Ran the tests locally with
indexmap==v1.9.2
:(Tried running
cargo xtask ci
but it failed on some warnings in the generated FFI code)This relaxes the restrictions on
indexmap
so that the latest version is also supported,hope that's okay.
Cheers,
Gilad