Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy::redundant_closure lint firing for pyfunction defaults #2990

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Fix clippy::redundant_closure lint firing for pyfunction defaults #2990

merged 1 commit into from
Feb 28, 2023

Conversation

davidhewitt
Copy link
Member

Fixes #2988

I'll push a follow-up for the FIXME as a separate PR.

@davidhewitt davidhewitt mentioned this pull request Feb 27, 2023
Closed
@adamreichold
Copy link
Member

Will give this a try together with #2991

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 28, 2023

Build succeeded:

@bors bors bot merged commit 794755c into PyO3:main Feb 28, 2023
@davidhewitt davidhewitt mentioned this pull request Feb 28, 2023
Merged
bors bot added a commit that referenced this pull request Feb 28, 2023
@bors @davidhewitt
Merge #2993
c28edd0 
2993: fix `non_snake_case` lint for `#[pyfunction]` generated code r=davidhewitt a=davidhewitt

As promised in #2990 

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
@davidhewitt davidhewitt mentioned this pull request Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird clippy issue when vecs are used in signature
2 participants
@davidhewitt @adamreichold