Add Python::with_pool as a safer alternative to Python::new_pool. #3263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am still somewhat sceptical about adding this as an unsafe API on stable. Both because the unsafe of calling
with_pool
"infects" the closure body which is now necessarily unsafe as well and because I see the argument applying toallow_threads
which would need to be unsafe stable for the same reasons.Personally, I think this somewhat diminishes gains made from switching to the more limited API and would hence suspect users sticking to the existing API even though it is much more prone to misuse, i.e. at the end of day I expect more programmer mistakes than if we made the API safe and ate the soundness hole just like we do for
allow_threads
.