Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent traceback loss on conversion to and from PyErr #3328

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Prevent traceback loss on conversion to and from PyErr #3328

merged 2 commits into from
Jul 19, 2023

Conversation

zakstucke
Copy link
Contributor

Fixes #3327

davidhewitt
davidhewitt approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@davidhewitt davidhewitt added this pull request to the merge queue Jul 19, 2023
Merged via the queue into PyO3:main with commit d69ca4f Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold left review comments

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyErr drops the traceback on into_py(py).
3 participants
@zakstucke @davidhewitt @adamreichold