Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyType_GetDict for Python 3.12 #3339

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Add PyType_GetDict for Python 3.12 #3339

merged 1 commit into from
Jul 24, 2023

Conversation

@adamreichold adamreichold added this pull request to the merge queue Jul 24, 2023
@cdce8p
Copy link
Contributor Author

cdce8p commented Jul 24, 2023

Would it be possible to get this backported and released with 1.19.2? It's necessary to build some packages for 3.12. E.g. ijl/orjson#408

@adamreichold
Copy link
Member

Would it be possible to get this backported and released with 1.19.2? It's necessary to build some packages for 3.12. E.g. ijl/orjson#408

We are still working on compatibility with Python 3.12 and plan a 0.19.x point release which contains mainly that. I suspect we will need to make use of this ourselves, so I am sure it will be cherry-picked into that release too. It might still take a while though.

Merged via the queue into PyO3:main with commit 8c393dd Jul 24, 2023
31 checks passed
@adamreichold
Copy link
Member

(Note that while it should of course end up in a released version here, you can fix this in downstream crates by adding the extern "C" declaration there if you need this urgently. Not something I would generally recommend, but it should work as long as one of the dependencies pulls in the defining DSO.)

@cdce8p cdce8p deleted the pytype-getdict branch July 24, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants