optimize float
-> f64
conversions on non-abi3
#3345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On non-abi3 builds we can use
PyFloat_AS_DOUBLE
to avoid an FFI function call and instead read the double value directly from thePyFloatObject
structure.This gives nearly a 2x speedup to
f64
extraction when the input type isfloat
according to the benchmark I added:Given I would expect this is the majority case of
f64
conversions I think the slight bump in complexity is worth it given the drop in overhead.While I was at it I moved the ffi definitions around to match their positioning in 3.12's headers.