Add rename_all attribute to #[pyclass]
#3384
Conversation
|
I'll try to update the |
DataTriny
force-pushed
the
pyclass_rename_variants
branch
2 times, most recently
from
4f41e79
to
928c3f9
Compare
DataTriny
force-pushed
the
pyclass_rename_variants
branch
from
928c3f9
to
f02fe94
Compare
|
@adamreichold Ready for another review. |
|
codecov is failing again... I think I added enough tests and it can be ignored right? |
Yes, I think so too. The only reason I did not merge this yet is to give the other maintainers some time to chime in on this version of the code. |
| use pyo3::types::PyBool; | ||
|
|
||
| Python::with_gil(|py| { | ||
| let struct_class = py.get_type::<StructWithRenamedFields>(); | ||
| let struct_obj = struct_class.call0().unwrap(); | ||
| assert!(struct_obj | ||
| .setattr("firstField", PyBool::new(py, false)) | ||
| .is_ok()); | ||
| py_assert!(py, struct_obj, "struct_obj.firstField == False"); | ||
| py_assert!(py, struct_obj, "struct_obj.secondField == 5"); | ||
| assert!(struct_obj | ||
| .setattr("third_field", PyBool::new(py, true)) | ||
| .is_ok()); | ||
| py_assert!(py, struct_obj, "struct_obj.third_field == True"); | ||
| }); |
There was a problem hiding this comment.
It would be quite nice to have some kind of macro here which can test each type of rename_all in turn, so that we test they all work as expected.
test_case!(CamelCase, "camelCase", "ab_cd-ef", "abCdEf");
test_case!(SnakeCase, "snake_case", "ab_cd-ef", "ab_cd_ef");etc
There was a problem hiding this comment.
I added a macro which I think does the job. At least codecov likes it.
Closes #3383