Remove IntoPyPointer #3385
Merged
Remove IntoPyPointer #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
remove-into-py-pointer
branch
from
4088f7a to
9cfcda5
Compare
adamreichold
approved these changes
Aug 14, 2023
davidhewitt
reviewed
Aug 14, 2023
There was a problem hiding this comment.
I am happy to see this go, especially given #3325, however I think we should add a note in the migration guide given we're not giving this a deprecation cycle.
it wasn't used in any public APIs following PyO3#3359
alex
force-pushed
the
remove-into-py-pointer
branch
from
9cfcda5 to
5061b50
Compare
|
Good call, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it wasn't used in any public APIs following #3359
refs #3358