Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses io::Error code when converting io::IntoInnerError to PyErr #3396

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Uses io::Error code when converting io::IntoInnerError to PyErr #3396

merged 1 commit into from
Aug 18, 2023

Conversation

Tpt
Copy link
Contributor

@Tpt Tpt commented Aug 17, 2023

No description provided.

@Tpt
Copy link
Contributor Author

Tpt commented Aug 17, 2023

No test: io::IntoInnerError has no public constructor, making a unit test very cumbersome

davidhewitt
davidhewitt approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good consistency change!

@davidhewitt davidhewitt added this pull request to the merge queue Aug 18, 2023
Merged via the queue into PyO3:main with commit 7f32ed9 Aug 18, 2023
30 of 31 checks passed
@Tpt Tpt deleted the IntoInnerError branch August 18, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold approved these changes

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tpt @davidhewitt @adamreichold