Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix escaping of llvm-cov output #3413

Merged
merged 2 commits into from
Aug 25, 2023
Merged

fix escaping of llvm-cov output #3413

merged 2 commits into from
Aug 25, 2023

Conversation

davidhewitt
Copy link
Member

Looks like the output of cargo llvm-cov show-env changed from escaped by " to '. I think that's the cause of our CI issues.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Aug 25, 2023
@davidhewitt
Copy link
Member Author

I'll also add updates for Rust 1.72 to this PR...

@davidhewitt davidhewitt added this pull request to the merge queue Aug 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 25, 2023
@davidhewitt davidhewitt added this pull request to the merge queue Aug 25, 2023
noxfile.py Outdated Show resolved Hide resolved
Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo clippy::if_same_then_else on the Python code.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 25, 2023
@davidhewitt davidhewitt added this pull request to the merge queue Aug 25, 2023
Merged via the queue into PyO3:main with commit 23fd73e Aug 25, 2023
31 checks passed
@davidhewitt davidhewitt deleted the llvm-cov branch August 25, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants