propagate exception context from pyfunctions #3443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3432
Our current implementation of
PyErr::restore(before 3.12) doesn't propagate exception context when inside of anexceptblock. This appears to be the root cause of #3432.This PR attempts to resolve that and make the code paths between 3.12 and older versions more similar. I think there's more tidying up to do and might even be worth splitting into separate PRs to make motivations clear. Pushing this here so the code doesn't get forgotten while I multitask. Don't think it's necessarily worth reviewing yet.