Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit compile errors on macros inside #[pymethods] #3491

Merged
merged 1 commit into from
Oct 2, 2023
Merged

emit compile errors on macros inside #[pymethods] #3491

merged 1 commit into from
Oct 2, 2023

Conversation

davidhewitt
Copy link
Member

Fixes #2862

This is a small UX improvement to raise an error instead of silently ignoring macro invocations inside #[pymethods].

mejrs
mejrs approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@mejrs mejrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea this was accepted 😟

pyo3-macros-backend/src/pyimpl.rs Outdated Show resolved Hide resolved
@davidhewitt @mejrs
emit compile errors on macros inside #[pymethods]
a1d333a 
Co-authored-by: Bruno Kolenbrander <59372212+mejrs@users.noreply.github.com>
@davidhewitt davidhewitt added this pull request to the merge queue Oct 2, 2023
Merged via the queue into PyO3:main with commit 5b7885b Oct 2, 2023
31 of 32 checks passed
@davidhewitt davidhewitt deleted the pymethods-macro-error branch October 2, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejrs mejrs mejrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functions implemented with macro are not treated as python methods in block #[pymethod]
2 participants
@davidhewitt @mejrs