Add support for SmallVec in conversion traits (#3440)
#3507
Conversation
orhun
force-pushed
the
feat/support_smallvec_conversion
branch
3 times, most recently
from
9834626 to
e5eda2b
Compare
orhun
force-pushed
the
feat/support_smallvec_conversion
branch
from
e5eda2b to
dfeae47
Compare
|
Thank you! FYI other maintainers this was built with my collaboration in the EuroRust impl room, so it's best if I don't review (but can be responsible for follow up tidying). |
Cargo.toml
Outdated
| @@ -41,6 +41,7 @@ num-bigint = { version = "0.4", optional = true } | |||
| num-complex = { version = ">= 0.2, < 0.5", optional = true } | |||
| rust_decimal = { version = "1.0.0", default-features = false, optional = true } | |||
| serde = { version = "1.0", optional = true } | |||
| smallvec = { version = "1.11.1", optional = true } | |||
There was a problem hiding this comment.
What do you mean? "smallvec = 1.0"
There was a problem hiding this comment.
Yes, in general we try to accept as broad ranges of optional dependency versions as possible so that we don't have to force users to use specific versions.
There was a problem hiding this comment.
Got it, made the change in 87cbd38
|
Added in 31acf0d |
There was a problem hiding this comment.
Thanks again @orhun and good to meet you at EuroRust - I think this looks good now, so I'll merge it 👍
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
CI failure looks caused by latest psutil release; I can try to fix separately later. |
|
Thanks @davidhewitt, it was nice to meet you as well, wish to see you again in events/open source world! |
closes #3440