Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change PyDict::from_sequence to take just &PyAny #3532

Merged
merged 1 commit into from
Oct 20, 2023
Merged

change PyDict::from_sequence to take just &PyAny #3532

merged 1 commit into from
Oct 20, 2023

Conversation

davidhewitt
Copy link
Member

This is similar to #3389 in changing a two-argument function to take just &PyAny. Hopefully not controversial!

@davidhewitt davidhewitt mentioned this pull request Oct 20, 2023
Closed
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2023

CodSpeed Performance Report

Merging #3532 will improve performances by 10.14%

Comparing davidhewitt:dict-from-seq (d895734) with main (d8a6f37)

Summary

⚡ 1 improvements
✅ 77 untouched benchmarks

Benchmarks breakdown

Benchmark main davidhewitt:dict-from-seq Change
⚡ list_via_extract 301.7 ns 273.9 ns +10.14%

@adamreichold adamreichold added this pull request to the merge queue Oct 20, 2023
Merged via the queue into PyO3:main with commit 9d75325 Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex alex alex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidhewitt @alex @adamreichold