Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix missing char conversion #3570

Merged
merged 1 commit into from
Nov 15, 2023
Merged

docs: fix missing char conversion #3570

merged 1 commit into from
Nov 15, 2023

Conversation

subygan
Copy link
Contributor

@subygan subygan commented Nov 10, 2023

Thank you for contributing to PyO3!

By submitting these contributions you agree for them to be dual-licensed under PyO3's MIT OR Apache-2.0 license.

Please consider adding the following to your pull request:

  • an entry for this PR in newsfragments - see [https://pyo3.rs/main/contributing.html#documenting-changes]
    • or start the PR title with docs: if this is a docs-only change to skip the check
  • docs to all new functions and / or detail in the guide
  • tests for all new or changed functions

PyO3's CI pipeline will check your pull request. To run its tests
locally, you can run nox. See nox --list-sessions
for a list of supported actions.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@subygan
Copy link
Contributor Author

subygan commented Nov 10, 2023

Very curious that the pipeline is failing. the commands are running on my local

@davidhewitt davidhewitt added this pull request to the merge queue Nov 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 10, 2023
@davidhewitt davidhewitt added this pull request to the merge queue Nov 10, 2023
@davidhewitt
Copy link
Member

Yes, seems like just some flakiness 😭

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 10, 2023
@davidhewitt davidhewitt added this pull request to the merge queue Nov 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 10, 2023
@alex alex added this pull request to the merge queue Nov 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2023
@davidhewitt davidhewitt added this pull request to the merge queue Nov 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2023
@davidhewitt
Copy link
Member

Ugh, I've asked upstream at rust-lang/rustup#3530

@davidhewitt davidhewitt added this pull request to the merge queue Nov 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2023
@davidhewitt davidhewitt added this pull request to the merge queue Nov 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2023
@davidhewitt davidhewitt added this pull request to the merge queue Nov 15, 2023
Merged via the queue into PyO3:main with commit 1e28ba7 Nov 15, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants