Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an associated type
AsRefSource
toPyNativeType
.This allows type inference in the reverse direction
&T -> Py<T>
, which is particularly useful for&PyCell<T> -> Py2<T>
. It also helps for forwarding our gil-ref methods to the new traits, e.g. by solving the inference problem in #3652Really this is most helpful when we're in a transition phase where users might be using
Py2::borrowed_from_gil_ref
themselves. So I'm also happy to decide that we don't merge this until we're ready to releasePy2
as a whole, and for now we just continue to add type annotations while we're landing the groundwork internally.