-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement datetime traits for Bound
#3679
Conversation
CodSpeed Performance ReportMerging #3679 will improve performances by 22.03%Comparing 🎉 Hooray!
|
Benchmark | main |
davidhewitt:datetime2 |
Change | |
---|---|---|---|---|
⚡ | list_via_extract |
153.9 ns | 126.1 ns | +22.03% |
31aad2e
to
aae7653
Compare
Bound
aae7653
to
20c7a06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The CI says the pytests still need to be adjusted though.
20c7a06
to
6832bf8
Compare
Thanks for fixing those up! I ended up getting a bit deep into rebasing #3606 for the new |
Split from #3606
This works a bit differently from the other
PyXMethods
traits, because we already have traits for the datetime types, so we can just implement them forBound
types.The only slight snag is that
PyTzInfoAccess
returns a gil-ref, sofor now I've addedI've had to modify that to return aPyTzInfoAccess2
(and we can clean that up when we make the new API public)Bound
tzinfo instead.