Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance of successful int extract by ~30% by avoiding calls to __index__ where redundant #3742

Merged
merged 1 commit into from
Jan 16, 2024

improve performance of successful int extract by ~30%

0e876d9
Select commit
Loading
Failed to load commit list.
Merged

improve performance of successful int extract by ~30% by avoiding calls to __index__ where redundant #3742

improve performance of successful int extract by ~30%
0e876d9
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Jan 16, 2024 in 0s

Performance Regression: -18.05%

Summary

⚡ 13 improvements
❌ 2 regressions
✅ 63 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main samuelcolvin:int-extraction-performance Change
extract_int_downcast_fail 266.1 ns 238.3 ns +11.66%
extract_str_extract_success 647.2 ns 730.6 ns -11.41%
extract_int_downcast_success 902.2 ns 635.6 ns +41.96%
extract_int_extract_success 893.9 ns 627.2 ns +42.52%
tuple_get_item 18.7 ms 14.4 ms +30.11%
not_a_list_via_downcast 126.1 ns 153.9 ns -18.05%
tuple_get_item_unchecked 15.5 ms 11.1 ms +38.9%
extract_btreeset 87.6 ms 78.9 ms +10.99%
list_get_item 22.5 ms 18.1 ms +23.88%
iter_list 37.8 ms 29.1 ms +29.76%
iter_dict 57.6 ms 48.9 ms +17.72%
iter_tuple 27.1 ms 18.4 ms +47.01%
list_get_item_unchecked 19.4 ms 15.1 ms +28.77%
extract_hashmap 111.3 ms 94 ms +18.43%
iter_set 60.6 ms 51.9 ms +16.7%