remove test_pep_587
#3769
Merged
remove test_pep_587
#3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3762
This test uses
_Py_InitializeMainas part of its machinery for testing PEP 587 embedding. Also, it was originally built as a crude way to check that the FFI structure definitions were correct.It was originally introduced in #2374 and
pyo3-ffi-checkdidn't come until later in #2423.So, I think that for now it's best if we just remove this test, to get rid of the CPython-private
_Py_InitializeMainusage.I suspect that once we drop Python 3.7 we'll be implementing some new replacement for
prepare_freethreaded_pythonwhich uses the PEP 587 APIs, so at that point we'll be adding more coverage again too.