deprecate the use of PyCell in favor of Bound and Py
#3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icxolu
force-pushed
the
pycell-deprecation
branch
2 times, most recently
from
f3f21df
to
3a0e958
Compare
63 tasks
Icxolu
force-pushed
the
pycell-deprecation
branch
from
3a0e958
to
23a86cc
Compare
|
I have rebased this, but maybe it makes sense to land this after #3917 |
davidhewitt
reviewed
Mar 1, 2024
There was a problem hiding this comment.
Generally this looks great, thanks as always. Had just a few small thoughts.
Regarding the ordering, I guess if I get #3917 merged first then it'll be possible to get a lot of the implementation migrated without the deprecation allows going everywhere. I'll try and complete that in a moment...
Icxolu
force-pushed
the
pycell-deprecation
branch
from
067c4b3
to
5e5bed6
Compare
Icxolu
force-pushed
the
pycell-deprecation
branch
from
5e5bed6
to
2977f9b
Compare
LilyFoote
approved these changes
Mar 3, 2024
davidhewitt
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3684, following #3914 (review)
This deprecates
PyCellin favor ofBoundandPy.For most of the implementation I just added
#[allow(deprecated)], so there might so still some opportunity for refactoring. The tests I have adjusted to the new API.Edit: I marked this as draft, since it depends on #3914