Implement Iterator for Bound<'py, PySequence> #3927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #3923 I noticed that we didn't have an implementation of
Iterator
forPySequence
. I'm not 100% certain this is the right thing to add, since it hides the fallibility oflen
andget_item
with.expect
calls. But a properly implemented PythonSequence
shouldn't raise in these, so maybe the ergonomics justify allowing panics here?If we want this, I think now would be a good time to add it, since the changes to error handling it introduces would be straightforward as part of the general
Bound
migration.