remove gil-refs feature from full feature
#3930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyFoote
approved these changes
Mar 4, 2024
LilyFoote
reviewed
Mar 4, 2024
| @@ -980,13 +980,13 @@ mod tests { | |||
| let td = new_py_datetime_ob(py, "timedelta", (0, 3600, 0)); | |||
| let py_timedelta = new_py_datetime_ob(py, "timezone", (td,)); | |||
| // Should be equal | |||
| assert!(offset.as_ref(py).eq(py_timedelta).unwrap()); | |||
| assert!(offset.bind(py).eq(py_timedelta).unwrap()); | |||
There was a problem hiding this comment.
It's a bit interesting to me that we didn't catch these before now.
There was a problem hiding this comment.
I think it's a result of us not testing the full feature without GIL Refs previously. As soon as I split the features, vscode started shouting at me 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
gil-refsfeature from thefullfeature. This makes it possible to test thefullfeature with and without thegil-refsenabled, which I think is a meaningful thing to do while we're in the migration phase, even if it makes our CI longer for the mid term.Because the
gil-refsfeature is large and expected to get complicated I've also enabled this as an additional dimension to thecheck-feature-powersetjob.I'm hoping that between enabling tests with
full(but not withabi3, for sake of not going too heavy on CI) and using the powerset check to exercise all compile combinations, we should be in a good place for things to work well with and without the feature.