Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add experimental-async feature #3931

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Conversation

davidhewitt
Copy link
Member

Closes #3848

As proposed in that issue, this PR adds an experimental-async feature. I think it's pretty close to done, but we didn't ever merge the last parts. I'd like to mark it as experimental to give us a bit of extra mandate to make changes to things like the Coroutine type as well as denote this as somewhere we'd like some extra user input.

Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link

codspeed-hq bot commented Mar 6, 2024

CodSpeed Performance Report

Merging #3931 will improve performances by 10.74%

Comparing davidhewitt:experimental-async (fcdcbc7) with main (b08ee4b)

Summary

⚡ 1 improvements
✅ 66 untouched benchmarks

Benchmarks breakdown

Benchmark main davidhewitt:experimental-async Change
extract_float_downcast_fail 572.8 ns 517.2 ns +10.74%

@davidhewitt davidhewitt added this pull request to the merge queue Mar 6, 2024
Merged via the queue into PyO3:main with commit 57bbc32 Mar 6, 2024
41 of 42 checks passed
@davidhewitt davidhewitt deleted the experimental-async branch March 6, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of pyo3-macros within PyO3's main crate makes development harder
2 participants