Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrono: allow deprecation warning until upgrading to 0.4.35+ #3935

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Chrono: allow deprecation warning until upgrading to 0.4.35+ #3935

merged 2 commits into from
Mar 6, 2024

Conversation

Tpt
Copy link
Contributor

@Tpt Tpt commented Mar 6, 2024

Requirering 0.4.35 is blocked on MSRV (Chrono: 1.61, PyO3: 1.56)

@Tpt Tpt mentioned this pull request Mar 6, 2024
Merged
@Tpt
Chrono: allow deprecation warning until upgrading to 0.4.35+
e981fdb 
Requiring 0.4.35 is blocked on MSRV (Chrono: 1.61, PyO3: 1.56)
@Tpt Tpt force-pushed the chrono-depreciation branch from 3244543 to e981fdb Compare March 6, 2024 14:41
davidhewitt
davidhewitt approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes this seems like the most practical option for now. I think we are probably going to bump our MSRV as part of 0.22 (which might not be far off now).

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Mar 6, 2024
@davidhewitt davidhewitt enabled auto-merge March 6, 2024 17:30
@davidhewitt davidhewitt added this pull request to the merge queue Mar 6, 2024
Merged via the queue into PyO3:main with commit d35f41e Mar 6, 2024
40 checks passed
@Tpt Tpt deleted the chrono-depreciation branch March 11, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tpt @davidhewitt