adjust path for GIL Refs deprecation warnings #3968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the UI tests are emitting warnings like
That
pyo3::methods
path bothered me as I want to deprecate that module (probably a 0.22 thing at this point). I thought we might be able to get something more meaningful, so I shuffled code around a little. Now we get:Do folks think this is any nicer? Think we can make the path even better for readers?
cc @Icxolu as this probably will have merge conflicts with code you're typing 😬