Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle clippy new_without_default warnings #3971

Merged
merged 2 commits into from
Mar 19, 2024
Merged

handle clippy new_without_default warnings #3971

merged 2 commits into from
Mar 19, 2024

Conversation

davidhewitt
Copy link
Member

clippy on beta toolchain is failing with warnings about some structs which have fn new() but no Default implementation.

For the FFI and internal ones I just silenced the warning for now, but for GILOnceCell this seemed reasonable to add.

@davidhewitt davidhewitt added this pull request to the merge queue Mar 19, 2024
Merged via the queue into PyO3:main with commit caf80ec Mar 19, 2024
41 of 42 checks passed
@davidhewitt davidhewitt deleted the clippy-defaults branch March 19, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Icxolu Icxolu Icxolu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @Icxolu