Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: updates for Rust 1.77 #3978

Merged
merged 2 commits into from
Mar 22, 2024
Merged

ci: updates for Rust 1.77 #3978

merged 2 commits into from
Mar 22, 2024

Conversation

davidhewitt
Copy link
Member

UI test updates for Rust 1.77

There are quite a few interesting detail additions here for the diagnostics. Maybe eventually we should try to simplify some of these messages by adjusting implementation details. For now I think this is fine.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Mar 22, 2024
@davidhewitt davidhewitt enabled auto-merge March 22, 2024 19:46
@davidhewitt davidhewitt added this pull request to the merge queue Mar 22, 2024
@davidhewitt davidhewitt removed this pull request from the merge queue due to a manual request Mar 22, 2024
@davidhewitt davidhewitt enabled auto-merge March 22, 2024 20:02
Copy link

codspeed-hq bot commented Mar 22, 2024

CodSpeed Performance Report

Merging #3978 will improve performances by 26.94%

Comparing davidhewitt:rust-1.77 (5670357) with main (351c6a0)

Summary

⚡ 1 improvements
✅ 66 untouched benchmarks

Benchmarks breakdown

Benchmark main davidhewitt:rust-1.77 Change
extract_str_extract_success 735.6 ns 579.4 ns +26.94%

@davidhewitt
Copy link
Member Author

For what it's worth, from the codspeed flame graph it looks like the performance win here can be attributed to better inlining on that particular benchmark.

@davidhewitt davidhewitt added this pull request to the merge queue Mar 22, 2024
Merged via the queue into PyO3:main with commit d0f5b6a Mar 22, 2024
41 of 42 checks passed
@davidhewitt davidhewitt deleted the rust-1.77 branch March 22, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants