-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 0.21.0 #3983
release: 0.21.0 #3983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!! Just one minor suggestion.
- `chrono-tz` feature allowing conversion between `chrono_tz::Tz` and `zoneinfo.ZoneInfo` [#3730](https://github.com/PyO3/pyo3/pull/3730) | ||
- Add definition for `PyType_GetModuleByDef` to `pyo3_ffi`. [#3734](https://github.com/PyO3/pyo3/pull/3734) | ||
- Add methods to `PyAnyMethods` for binary operators (`add`, `sub`, etc.) [#3712](https://github.com/PyO3/pyo3/pull/3712) | ||
- Add `chrono-tz` feature allowing conversion between `chrono_tz::Tz` and `zoneinfo.ZoneInfo` [#3730](https://github.com/PyO3/pyo3/pull/3730) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move this up next to the other chrono
entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far in the changelog the convention is generally to order bullets by their PR number (i.e. vaguely chronological). Although that's a pretty arbitrary ordering that's not necessarily useful anyway, I don't feel a strong need to make an exception here.
ecbb5e8
to
5d25d63
Compare
CodSpeed Performance ReportMerging #3983 will not alter performanceComparing Summary
|
My view is that I still intend to push this tonight after #3052 has merged and I have rebased. There's feedback coming in about the beta which is still helpful, but mostly it's documentation and small refinements. I think getting 0.21 shipped allows us to continue getting feedback and proceed to work on 0.22. I'm happy to take responsibility for cherry picking documentation and minor refinements onto a future 0.21.1 release as needed. |
Fwiw the coverage issue will be a blocker for cryptography, so once we have
a solution it'd be a valuable backport
…On Mon, Mar 25, 2024, 2:57 PM David Hewitt ***@***.***> wrote:
My view is that I still intend to push this tonight after #3052
<#3052> has merged and I have rebased.
There's feedback coming in about the beta which is still helpful, but
mostly it's documentation and small refinements. I think getting 0.21
shipped allows us to continue getting feedback and proceed to work on 0.22.
I'm happy to take responsibility for cherry picking documentation and
minor refinements onto a future 0.21.1 release as needed.
—
Reply to this email directly, view it on GitHub
<#3983 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBFGC7OL2J5Y6B4IGJLY2BXS5AVCNFSM6AAAAABFEFF5K6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJYGY4TENJUGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Good to know, I'll try to find time to look at that the other side of RustNation this week if nobody else solves sooner 👍 |
5d25d63
to
d854ea0
Compare
Release is live! |
I think we're finally ready to release PyO3 0.21.0!
To deal with keeping the CHANGELOG entry cleaner, I've proposed to remove the release notes for the beta version and just leave a pointer to the GitHub diff for the few users who ever want to care about the beta release. I also took this moment to edit the wording in the CHANGELOG a bit for consistency, as I didn't do that when preparing the beta release from the newsfragments.
I've set an arbitrary date of Monday to put this release live.
I'll probably rebase this once before pushing live, to pick up #3982 and anything else which comes in between now and then.