ci: use macos-14 runners #3985
Merged
ci: use macos-14 runners #3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
commented
Mar 23, 2024
| @@ -119,7 +119,7 @@ jobs: | |||
| rust-target: "x86_64-unknown-linux-gnu", | |||
| } | |||
| name: clippy/${{ matrix.platform.rust-target }}/${{ matrix.rust }} | |||
| continue-on-error: ${{ matrix.platform.rust != 'stable' }} | |||
| continue-on-error: ${{ matrix.rust != 'stable' }} | |||
There was a problem hiding this comment.
While updating I noticed that this setting was wrong; this is why the macOS aborts in CI are not blocking pull requests.
.github/workflows/ci.yml
Outdated
Comment on lines
165
to
166
| python-architecture: "x64", | ||
| rust-target: "aarch64-apple-darwin", |
There was a problem hiding this comment.
An oversight from me that probably needs correcting 👀
There was a problem hiding this comment.
Based on the filenames at https://github.com/actions/python-versions/releases, I think this needs to be arm64
davidhewitt
force-pushed
the
macos-clippy
branch
from
e08293c to
dfc831f
Compare
|
Architecture: arm64 was a good spot; it looks like that indeed is now using the system Python (presumably leaving x64 had left it to run under rosetta). The macOS-14 builds are now the fastest ones in the build matrix! I'm going to proceed to merge this both for the speedups and also so that clippy-on-macos stops being red. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes moving to arm macOS runners for CI, as they are faster than the x86_64 ones. We are having some aborts in
clippymacOS job and I wonder if this change will also sweep that problem under the rug.For the full build matrix I stuck with x86_64 runners, as I think not all Python versions in our matrix currently support arm. I just added arm job for Python 3.12 for now. We can update that in future.