Change search_lib_dir's return type to Result
#4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't aware of how to test it, so |
pyo3-build-config/src/impl_.rs
Outdated
| let mut sysconfig_paths = vec![]; | ||
| for f in fs::read_dir(path).expect("Path does not exist") { | ||
| for f in fs::read_dir(path) | ||
| .context("failed to search the lib dir, please check your path and permissions.")? |
There was a problem hiding this comment.
I think we should name the relevant environment variables here or possibly add more targeted calls to context at the call sites of search_lib_dir so the user knows what to check exactly.
There was a problem hiding this comment.
Added a reference to PYO3_CROSS_LIB_DIR
This was referenced Jun 21, 2024
|
I pushed a commit to add a test and more clarity on the hints. Let's merge this; thanks @reswqa for getting this moving (and sorry I took so long to add input here)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #3952.