Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link libpython for AIX target #4073

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Conversation

messense
Copy link
Member

Closes #4068

@adamreichold adamreichold added this pull request to the merge queue Apr 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 13, 2024
@adamreichold adamreichold added this pull request to the merge queue Apr 13, 2024
@adamreichold
Copy link
Member

@messense Any idea why the hashes of the Maturin wheels changed?

image

@messense
Copy link
Member Author

No idea, no changes made to pypi after 1.5.1 release.

@adamreichold
Copy link
Member

Oh my, with the whole xz situation, this feels really weird.

I think the lock file in question here is part of the CI cache instead of coming from our source. So could it be that an update to Pip or the recent chance to the macOS runners affected this somehow? But wouldn't it also affect the filename then?

@adamreichold
Copy link
Member

Ok, so now coverage worked but the normal macOS build failed with the exact same error message and hash value. Which does seem to make a cache issue more likely?

@adamreichold adamreichold removed this pull request from the merge queue due to a manual request Apr 13, 2024
@adamreichold adamreichold added this pull request to the merge queue Apr 13, 2024
Merged via the queue into PyO3:main with commit 30348b4 Apr 13, 2024
42 of 43 checks passed
@messense messense deleted the aix-link-libpython branch April 13, 2024 08:48
davidhewitt pushed a commit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python ld flags not detected...
2 participants