Disable PyUnicode_DATA on PyPy #4116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyFoote
approved these changes
Apr 24, 2024
adamreichold
approved these changes
Apr 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Please make sure to adjust the imports in the relevant configurations. |
dmatos2012
force-pushed
the
disable-unicode-data-for-pypy
branch
from
84a6313 to
fce6d6a
Compare
|
Changed the imports in such a way that I did not have to disable the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ,
This should close #4040 which caused
segfaultwhenPyUnicode_DATAwas used onPyPy.I disabled some
testsonPyPyas they reached intodata()which I think is correct, but I am also new in thisffiareas, so If there is a test I need to add or something else that im missing, please let me know, glad to help.