Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV to 1.63 #4129

Merged
merged 4 commits into from
Apr 28, 2024
Merged

Update MSRV to 1.63 #4129

merged 4 commits into from
Apr 28, 2024

Conversation

alex
Copy link
Contributor

@alex alex commented Apr 26, 2024

No description provided.

@alex
Copy link
Contributor Author

alex commented Apr 26, 2024

Hmm, the msrv job is failing, but I don't quite understand why.

Copy link

codspeed-hq bot commented Apr 26, 2024

CodSpeed Performance Report

Merging #4129 will degrade performances by 17.44%

Comparing alex:rm-parking-lot (fea5ddd) with main (6fb972b)

Summary

❌ 1 regressions
✅ 68 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main alex:rm-parking-lot Change
drop_many_objects 55.2 µs 66.9 µs -17.44%

@alex alex force-pushed the rm-parking-lot branch 2 times, most recently from 156e0b6 to 0fb0407 Compare April 26, 2024 15:35
@alex
Copy link
Contributor Author

alex commented Apr 26, 2024

Woo! With enough elbow grease, got it working

@alex alex force-pushed the rm-parking-lot branch 2 times, most recently from 3e5b882 to ac5b2f3 Compare April 27, 2024 00:53
src/gil.rs Outdated Show resolved Hide resolved
Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the one nit in the Event helper.

@alex
Copy link
Contributor Author

alex commented Apr 28, 2024

Ok, should be good now.

@adamreichold adamreichold added this pull request to the merge queue Apr 28, 2024
Merged via the queue into PyO3:main with commit 9e1960e Apr 28, 2024
77 of 79 checks passed
@alex alex deleted the rm-parking-lot branch April 28, 2024 16:51
@Icxolu Icxolu mentioned this pull request May 1, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants