pypy/graalpy: set Py_LIMITED_API when abi3 requested
#4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
pypy-limited-api
branch
from
9234931 to
814549c
Compare
davidhewitt
force-pushed
the
pypy-limited-api
branch
from
814549c to
0049915
Compare
LilyFoote
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the CI failure attempting to merge #4194
This PR changes the
abi3builds on PyPy and GraalPy so that if theabi3feature is set they will still set thePy_LIMITED_APIconfig.Technically speaking this is a bit pointless because neither PyPy nor GraalPy support the
abi3stable ABI, but it makes it easier for us to reason about feature combinations because this way when theabi3feature is set we always build PyO3 to only use the limited API.I think these same changes would also make sense with #2865 because then the base cfg of the limited API would be the exact same code regardless of what interpreter implementation we're running on.