Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize declarative modules #4257

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Stabilize declarative modules #4257

merged 1 commit into from
Jun 17, 2024

Conversation

alex
Copy link
Contributor

@alex alex commented Jun 16, 2024

No description provided.

@alex alex force-pushed the stabalize-modules branch 3 times, most recently from 819b0b9 to 02036d5 Compare June 16, 2024 12:24
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! I'm glad to see this making it into 0.22!

newsfragments/4257.changed.md Outdated Show resolved Hide resolved
src/marker.rs Outdated Show resolved Hide resolved
@alex alex force-pushed the stabalize-modules branch from 02036d5 to 8ca4fb9 Compare June 16, 2024 15:10
@alex
Copy link
Contributor Author

alex commented Jun 16, 2024

Tests appear to be failing because of a numpy release from 2 hours ago 😂

@davidhewitt
Copy link
Member

Looks like our bool conversion needs to be adjusted to the new behaviour 😬

@alex
Copy link
Contributor Author

alex commented Jun 16, 2024

#4258 has the fix

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! Feel free to merge after #4258 unlocks this

@alex alex force-pushed the stabalize-modules branch from 8ca4fb9 to 18488fe Compare June 17, 2024 00:42
@alex alex enabled auto-merge June 17, 2024 00:43
@alex alex added this pull request to the merge queue Jun 17, 2024
Merged via the queue into PyO3:main with commit ddff8be Jun 17, 2024
41 checks passed
@alex alex deleted the stabalize-modules branch June 17, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants