Add several missing wrappers to PyAnyMethods #4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xen0n
force-pushed
the
more-pyany-methods
branch
from
9d3db2f to
8d48a7f
Compare
xen0n
force-pushed
the
more-pyany-methods
branch
from
8d48a7f to
ad31775
Compare
davidhewitt
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered these missing bits when I was working on a
starlark-rustbinding -- I had to forward between Python and Starlark most magic methods but some are missing inPyAnyMethods, for example those for//and%, among a couple of others.I have consulted the Python C API Number protocol and this seems complete. Please review and thanks for maintaining this great framework!